sozialhelden
Buttons to add wheelchair info on untagged places
🖊️ Description
💡 What? Why? How? Places without a wheelchair and/or wheelchair:toilet tag had no option to add such a tag. I added two buttons that are conditionally rendered when these tags are missing and open the respective editors. If a place has no wheelchair info at all, the add button for toilets:wheelchair is hidden until wheelchair info was added. This is the way it is handled on the old version of wheelmap.
➕ Additonal comments/questions
Since we want to rework the general ux flow for editing places, I decided to go for a minimal change and unspectacular look. In the future we will likely have only one edit button that toggles edit mode on and off for all editable tags. We will create an extra design concept for this.
I added tests for these buttons and some for the feature panel itself, but one of them just wont work and I dont know why 👺
🔗 PR Dependencies Depends on #569
⚠️ Creation checklist
Before creating this merge request, go over the following checklist (click to expand). Remove any items that are not applicable.
💪 I have tested my code
- [x] A new E2e playwright test covers this feature / A new test that reproduces the bug passes now.
- [ ] The feature deployment works.
- [] The automated tests are passing.
- [x] I have manually tested this feature
- [ ] on mobile
- [x] by using keyboard-only navigation
- [x] with a screen reader (VoiceOver is fine)
- [x] in Chrome
- [x] in Firefox
- [ ] in Safari
🧼 I have cleaned up my code
- [x] I have removed debug logging.
- [x] My code does not generate new warnings. commits in sensible chunks if possible).
🔍 I have performed a self-review of my code
- [x] My code is self-documenting or has links to necessary documentation.
- [x] New function and variables names can be understood by new developers with basic project knowledge.
- [x] The feature fits the design.
✨ I have created a nice pull request
- [x] It has a clear title.
- [x] It follows the template, has a clear description and testing instructions if needed.
- [x] It references applicable Asana tickets.
- [x] It targets the right branch.
- [x] I removed not applicable sections of the PR template.
- [ ] [optional] I added a GIF of my favorite animal to the PR description to lighten the mood of my colleagues.
🔍 Reviewing
When reviewing this merge request, here are some things to keep in mind:
