Add eula check

Open RiverHeart opened this issue 4 years ago • 3 comments

If "accept_eula" is required to install sql_server and the default value is false, we should let the user know instead of running the installer and letting it failing with a non-obvious error code

Obvious fix

Description

Adds warning to required attribute for server install

Check List

[ ] All tests pass. See TESTING.md for details.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

Apr 10 '21 19:04 RiverHeart

If accept_eula is required and defaults set it to false I'm not sure how this test ever passed unless it was overridden somewhere

"sql_server::server When all attributes are default, on Windows 2012, it should converge successfully converges successfully"

Apr 11 '21 16:04 RiverHeart

@RiverHeart for a unit test, you should check and see if by default it displays this error, otherwise you should set it to true so the other tests pass.

Apr 12 '21 17:04 ramereth

@RiverHeart for a unit test, you should check and see if by default it displays this error, otherwise you should set it to true so the other tests pass.

Will do!

Apr 12 '21 20:04 RiverHeart