Automated PR: Cookstyle Changes

Open kitchen-porter opened this issue 4 years ago • 1 comments

Hey! I ran Cookstyle 7.25.6 against this repo and here are the results. This repo was selected due to the topics of chef-cookbook

Changes

Issues found and resolved with resources/compile.rb

72:1 refactor: Chef/Modernize/ClassEvalActionClass - In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. (https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass)

Issues found and resolved with resources/install.rb

127:1 refactor: Chef/Modernize/ClassEvalActionClass - In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. (https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass)

Issues found and resolved with resources/rules.rb

18:1 refactor: Chef/Modernize/ClassEvalActionClass - In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. (https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass)

Issues found and resolved with resources/service.rb

5:26 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)
18:77 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)
30:26 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)
44:77 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)
48:1 refactor: Chef/Modernize/ClassEvalActionClass - In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. (https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass)
50:8 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)

Oct 12 '21 00:10 kitchen-porter

1 Warning

:warning: This Pull Request is probably missing tests.

	1 Warning
:warning:	This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

Oct 12 '21 00:10 kitchen-porter