snort icon indicating copy to clipboard operation
snort copied to clipboard

InSpec tests do not run on pull requests

Open simonwgill opened this issue 6 years ago • 3 comments

Cookbook version

4.0.1

Chef-client version

15.0.109

Platform Details

CircleCI 2.1

Scenario:

When I PRed my previous tiny change, it seemed odd that the check succeeded when I knew that the cookbook failed on many operating systems (issues to come).

Steps to Reproduce:

  1. Create a pull request to the sous-chef/snort repository

Expected Result:

I would expect that inspec tests would be run in CircleCI and the results would be available to the maintainers.

Actual Result:

linting and Dangerfile checks do occur. The kitchen converge and verify tasks do not.

simonwgill avatar Jan 01 '19 16:01 simonwgill

Hey,

would you like to submit a PR for this one? Examples can be found in the following repositories. If you need any guidance don't hesitate to ask, or stop by the Sous Chefs channel on the Chef Community Slack

https://github.com/sous-chefs/postgresql https://github.com/sous-chefs/haproxy

damacus avatar Jan 01 '19 17:01 damacus

I've caught up with the 2.0 orb and Xorima's circleci2.0 branch. I'm still finding the single flow of dokken to be a problem, so I'd rather stick with dokken-single for the moment.

Have somehow managed to close my pull request while faffing though, I'll get a new one done later for this stage.

simonwgill avatar Jun 20 '19 16:06 simonwgill

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

github-actions[bot] avatar Sep 30 '20 00:09 github-actions[bot]