postgresql icon indicating copy to clipboard operation
postgresql copied to clipboard

allow more mappings per mapname

Open kristofvandam opened this issue 6 months ago • 4 comments

Description

It is perfectly fine have more mappings per mapname, ref.

The current implementation doesn't allow repetitions of mapnames in pg_ident.conf, with this change an entry is unique based on map_name, system_username and database_username.

This allows for multiple system users to be mapped to a single database user.

Issues Resolved

No issue was created regarding tis PR

Check List

  • [X] A summary of changes made is included in the CHANGELOG under ## Unreleased
  • [X] New functionality includes testing.
  • [X] New functionality has been documented in the README if applicable.

kristofvandam avatar Jun 20 '25 11:06 kristofvandam

would fix https://github.com/sous-chefs/postgresql/issues/787

kristofvandam avatar Jun 20 '25 13:06 kristofvandam

Looks like we got a small test error. Ping me when this is fixed 👌

Thanks!

damacus avatar Jun 21 '25 10:06 damacus

Some tests are failing due to https://github.com/chef/chef/issues/15048. Without that fix i will be unable to fix the tests, after that fix i'll look into the rest.

I'm mainly testing against ident-17-debian-12, there the tests are succeeding (works on my machine :sweat_smile: )

kristofvandam avatar Jun 26 '25 06:06 kristofvandam

The indempotency issues we can ignore for now, but there are a large number of ident tests failing too which would suggest that this PR has either broken something or the tests need updating to match the new behaviour.

If we can get those sorted then this can be merged 👍

bmhughes avatar Jun 26 '25 09:06 bmhughes

There are a few things wrong here. So I'm going to bring them into the multi_ident_mapnames branch and fix them there. 👍🏼

damacus avatar Jul 14 '25 13:07 damacus