ntp icon indicating copy to clipboard operation
ntp copied to clipboard

Do not force set ntp servers

Open directionless opened this issue 8 years ago • 2 comments

There are cases where one does not want any ntp servers. Perhaps a node is using pools, or perhaps it's only using peers.

However, https://github.com/chef-cookbooks/ntp/pull/170 changed the behavior here. As implemented in https://github.com/rhass/ntp/blob/master/recipes/default.rb#L61-L69

if node['ntp']['servers'].empty?
  node.default['ntp']['servers'] = [
    '0.pool.ntp.org',
    '1.pool.ntp.org',
    '2.pool.ntp.org',
    '3.pool.ntp.org',
  ]
  Chef::Log.debug 'No NTP servers specified, using default ntp.org server pools'
end

I'm not sure this was intentional or accidental.

directionless avatar Nov 13 '17 18:11 directionless

Thanks for reporting. It looks like an unintended side effect of fixing this on mac os.

iennae avatar Nov 29 '17 04:11 iennae

I might have misblamed #170, this may have always been true (which would represent a bug with my initial pools PR)

Regardless, I have fixed this in #178

directionless avatar Dec 21 '17 16:12 directionless