pop() should work, argument errors

[explody]

Cookbook version

8.0.0

Chef-client version

>= 12.17

Platform Details

Ubuntu Trusty / Xenial

Scenario:

Use pop() methods in the various libraries.

Steps to Reproduce:

Try to pop a value out of a Nagios::Service, receive ArgumentError - wrong number of arguments (given 2, expected 1)

I'll note that pop() on Nagios::Host works as expected. The contents of the methods in the two classes is a bit different:

Service: https://github.com/sous-chefs/nagios/blob/8a909f251ce18c439714e2864e1f948f24051d8b/libraries/service.rb#L199-L206

I can't see any way that L205 would work, and this is source of the exception

Compare to:

Host https://github.com/sous-chefs/nagios/blob/8a909f251ce18c439714e2864e1f948f24051d8b/libraries/host.rb#L177-L184

I have a PR available for this one too, but though it may warrant discussion in case my experience was unexpected.

[github-actions[bot]]

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

[ramereth]

@explody is this still an issue that needs to be addressed?