jenkins
jenkins copied to clipboard
sous-chefs
windows master support
Description
Adds support for Jenkins master on Windows
Issues Resolved
#437 , #547
Check List
- [ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
- [ ] New functionality includes testing.
- [x] New functionality has been documented in the README if applicable
- [x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD
The basic existing tests are working for me now. Given a run_list of:
- recipe[jenkins_server_wrapper::default]
- recipe[jenkins_plugin::install]
- recipe[jenkins_job::create]
- recipe[jenkins_user::create]
all tests pass in assert_plugin_installed_spec.rb, assert_job_created_spec.rb, & assert_user_created_spec.rb.
I started working on updating additional tests, but they don't all appear to be up-to-date/working (e.g. credentials_create has jenkins_password_credentials resources without id's specified, causing validation errors unrelated to this PR).
I don't want to prematurely check off the testing tasks, but FWIW the "new" functionality of install via MSI is covered and pretty much everything else leverages the web ui or local java execution (which is already tested). Open to suggestions on next steps.
@troyready can you rebase this on current master and verify all checks still pass. Then we can possibly get someone to review it.
I don't have the bandwidth to finish this now, sorry. The changes should be pretty straightforward for someone to pick up, only real functional change I think is figuring out the new conditional check for inspec (I think RUBY_PLATFORM.include?('mingw') will be wrong now given the local inspec execution)
@troyready / @dnorenavega-EDR can we get this rebased so we can look to have it merged please?
