firewall icon indicating copy to clipboard operation
firewall copied to clipboard

fix port sorting in generated firewall rules file

Open igolman opened this issue 2 years ago • 3 comments

Description

given ports argument als array of strings like:

firewall_rule 'allow some ports' do
  port %w(80 88 389 443 464 636)
  source '10.10.10.10'
end

generates in /etc/default/ufw-chef.rules file: ufw allow in proto tcp to any port 389,443,464,636,80,88 from 10.10.10.10 comment "allow some ports"

after this fix: ufw allow in proto tcp to any port 80,88,389,443,464,636 from 10.10.10.10 comment "allow some ports"

Issues Resolved

Correct generation of firewall rules.

Check List

  • [x] A summary of changes made is included in the CHANGELOG under ## Unreleased
  • [x] New functionality includes testing.
  • [x] New functionality has been documented in the README if applicable.

igolman avatar Dec 13 '23 22:12 igolman

Can you update the changelog as per the PR comments please 👍🏼

damacus avatar Dec 21 '23 09:12 damacus

Can you update the changelog as per the PR comments please 👍🏼

Done.

igolman avatar Dec 21 '23 11:12 igolman

Please look into failing tests

Stromweld avatar May 06 '24 19:05 Stromweld