firewall Fix Cant create ICMP firewall rules on windows

Description

on windows icmp rules must not specify port

Issues Resolved

https://github.com/chef-cookbooks/firewall/issues/156

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Jun 15 '17 14:06 alexandrezia

Can you fix the 2 failing checks so this can get merged into master? They seem like pretty trivial fixes.

Oct 27 '17 18:10 ianau74

Im having the same issue and a merge into master will be appreciated.

Oct 27 '17 18:10 mjavier2k

Any chance we can get this merged?

Feb 20 '18 18:02 smastrorocco

Hey @alexandrezia I realize this was opened a long time ago but would you be willing to resubmit this? If not, would it be okay if I resubmitted this as a different PR attribution to you?

Apr 02 '21 23:04 RiverHeart

Hey @alexandrezia I realize this was opened a long time ago but would you be willing to resubmit this? If not, would it be okay if I resubmitted this as a different PR attribution to you?

Hey, it was too long ago, I don't have context about this anymore, please go ahead, no worries.

Apr 02 '21 23:04 alexandre-zia-ifood

Hey @alexandrezia I realize this was opened a long time ago but would you be willing to resubmit this? If not, would it be okay if I resubmitted this as a different PR attribution to you?

Hey, it was too long ago, I don't have context about this anymore, please go ahead, no worries.

Thanks @alexandrezia :)

Apr 03 '21 00:04 RiverHeart