filesystem icon indicating copy to clipboard operation
filesystem copied to clipboard
verified publisher icon sous-chefs

Add input validation for label property

Open jasonwbarnett opened this issue 4 years ago • 4 comments

Description

mkfs.xfs has a maximum of 12 characters for the label (-L).

Ideally this would be merged after https://github.com/sous-chefs/filesystem/pull/105

Issues Resolved

N/A

Check List

  • [x] A summary of changes made is included in the CHANGELOG under ## Unreleased
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented in the README if applicable.

jasonwbarnett avatar Oct 05 '21 16:10 jasonwbarnett

Looks like we're blocked on LVM being updated.

I've just move it across to Sous-Chefs so it needs adopting and fixing to work with Chef 17

damacus avatar Oct 06 '21 15:10 damacus

@damacus I opened this up: https://github.com/sous-chefs/lvm/pull/210

jasonwbarnett avatar Oct 06 '21 15:10 jasonwbarnett

1 Warning
:warning: This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

kitchen-porter avatar Oct 14 '21 16:10 kitchen-porter

@jasonwbarnett can you please fix the issue on this PR? I rebased it and the other issues are fixed

ramereth avatar Oct 14 '21 21:10 ramereth