Fix ignored Route53 geolocation value

Open mach-kernel opened this issue 4 years ago • 2 comments

Description

If geo_location_country is specified, geo_location_subdivision will always be ignored. And you need to specify both arguments. Our use case is to replicate this Change to make a geolocation rule for Crimea:

<Change>
  <Action>CREATE</Action>
  <ResourceRecordSet>
    <Name>verysupercool.lookatme.example.com</Name>
    <Type>A</Type>
    <SetIdentifier>test</SetIdentifier>
    <GeoLocation>
      <CountryCode>UA</CountryCode>
      <SubdivisionCode>11</SubdivisionCode>
    </GeoLocation>
    <TTL>300</TTL>
    <ResourceRecords>
      <ResourceRecord>
        <Value>127.0.0.1</Value>
      </ResourceRecord>
    </ResourceRecords>
  </ResourceRecordSet>
</Change>

Issues Resolved

#geo_location no longer ignores geo_location_subdivision

Check List

[x] All tests pass. See TESTING.md for details.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

Jun 16 '21 20:06 mach-kernel

@mach-kernel please add a CHANGELOG entry

Jun 17 '21 20:06 ramereth

@ramereth added :)

Jun 18 '21 14:06 mach-kernel

Happy 2023

Jan 19 '23 20:01 mach-kernel