sourmash icon indicating copy to clipboard operation
sourmash copied to clipboard

consider importing rust code improvements from `sra_search`?

Open ctb opened this issue 1 year ago • 1 comments

in https://github.com/sourmash-bio/sra_search/pull/12, @luizirber defines some functions that seem to me like they would be nice to have in sourmash core -

  • fn check_compatible_downsample - check if two KerMinHash are compatible w/downsampling
  • fn prepare_query - downsample a sketch as needed (a replacement for sig.select_sketch

maybe we should consider bringing them in here?

ctb avatar Oct 03 '22 13:10 ctb

Note that they were both borrowed from #2230, so technically they will go in at some point. But can also make a smaller PR

luizirber avatar Oct 04 '22 00:10 luizirber