sourmash icon indicating copy to clipboard operation
sourmash copied to clipboard

[MRG] use stderr for test output printing

Open bluegenes opened this issue 1 year ago • 2 comments

Sets sys.stdout=sys.stderr, per https://github.com/sourmash-bio/sourmash/pull/2138#issuecomment-1216779696. Suggested as a solution to pytest-xdist not printing test output here: https://github.com/pytest-dev/pytest-xdist/issues/354#issuecomment-430502446

restores test output printing

@ctb is this a desired solution? Or did you find a better workaround?

bluegenes avatar Aug 16 '22 15:08 bluegenes

Codecov Report

Merging #2217 (ce0f648) into latest (651ecea) will increase coverage by 7.37%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2217      +/-   ##
==========================================
+ Coverage   84.66%   92.04%   +7.37%     
==========================================
  Files         131      100      -31     
  Lines       15512    11236    -4276     
  Branches     2210     2210              
==========================================
- Hits        13134    10342    -2792     
+ Misses       2085      601    -1484     
  Partials      293      293              
Flag Coverage Δ
python 92.04% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/index/sbt/mhbt.rs
src/core/tests/storage.rs
src/core/src/ffi/storage.rs
src/core/src/index/bigsi.rs
src/core/src/encodings.rs
src/core/src/sketch/nodegraph.rs
src/core/tests/minhash.rs
src/core/src/ffi/signature.rs
src/core/src/index/revindex.rs
src/core/src/ffi/minhash.rs
... and 21 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 16 '22 15:08 codecov[bot]

I can't think of a specific situation where it will cause problems, and we don't do anything particularly tricky with stdout/stderr outside of the script runner (runtmp.sourmash(...)) so ... let's give it a try and see!!

ctb avatar Aug 17 '22 13:08 ctb