sourmash icon indicating copy to clipboard operation
sourmash copied to clipboard

consider `SourmashSignature` downsample and flatten

Open ctb opened this issue 1 year ago • 0 comments

After https://github.com/sourmash-bio/sourmash/pull/1610, it seems like an obvious next set of simplifications is to remove all of the with x.update(): ... code blocks and replace them with flatten and/or downsample calls.

The only thing that prevents me from doing that now is that I'm not sure the abstraction is at the right level. Do we want to be making detailed calls about what to do with MinHash-specific information like abundances and scaled values, or do we want to be asking for "compatible" sketches on SourmashSignature objects, ref https://github.com/sourmash-bio/sourmash/issues/616?

ctb avatar Aug 03 '22 15:08 ctb