sourmash icon indicating copy to clipboard operation
sourmash copied to clipboard

[EXP] Use the bias factor for containment when estimating ANI

Open bluegenes opened this issue 2 years ago • 1 comments

bluegenes avatar May 17 '22 01:05 bluegenes

Codecov Report

Merging #2057 (2cc9906) into latest (647bb8e) will increase coverage by 7.37%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #2057      +/-   ##
==========================================
+ Coverage   84.81%   92.19%   +7.37%     
==========================================
  Files         131      100      -31     
  Lines       15621    11377    -4244     
  Branches     2238     2245       +7     
==========================================
- Hits        13249    10489    -2760     
+ Misses       2082      598    -1484     
  Partials      290      290              
Flag Coverage Δ
python 92.19% <100.00%> (+0.02%) :arrow_up:
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/minhash.py 94.08% <100.00%> (+0.32%) :arrow_up:
src/sourmash/search.py 97.94% <100.00%> (ø)
src/core/src/from.rs
src/core/src/signature.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/index/sbt/mod.rs
src/core/tests/test.rs
src/core/tests/storage.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/ffi/signature.rs
... and 23 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar May 17 '22 01:05 codecov[bot]

@bluegenes I think this is the last one that we want to consider before a sourmash 4.5 release, right? No hurry though, this can be released at any time as I do not think improving estimations requires a major or minor version bump (as long as we communicate it clearly in the release notes).

ctb avatar Aug 29 '22 14:08 ctb