sourmash icon indicating copy to clipboard operation
sourmash copied to clipboard

Published 20 hours ago • verified publisher icon sourmash-bio

should we remove `is_database` from `Index` objects?

Open ctb opened this issue 2 years ago • 2 comments

I don't think it serves a purpose any more; IIRC it was used to indicate that 'number of signatures' was not a useful designation Back When, but that is not really an internal distinction we use any more.

ctb avatar Mar 25 '22 14:03 ctb

short answer is "yes, we should remove it." It no longer serves a useful distinction.

ctb avatar Mar 25 '22 15:03 ctb

#2204 removes the use of is_database in sourmash_args database loading.

However, we can't remove is_database completely until v5 because it changes the output of sourmash sig summarize.

ctb avatar Aug 14 '22 15:08 ctb