sourcery icon indicating copy to clipboard operation
sourcery copied to clipboard

Sourcery should ignore `# noqa` lines

Open Bilbottom opened this issue 1 year ago • 1 comments

Checklist

  • [x] This is a new feature, not a refactoring suggestion
  • [x] I have checked for this feature in the Sourcery documentation
  • [x] I have checked there are no open requests referencing the same feature

Description

This might be a design choice (in which case, close this immediately 😋), but currently Sourcery doesn't ignore lines with the # noqa trailing comment. Although # noqa isn't a recommended way of suppressing QA warnings, there are occasional places where it's helpful.

It would be awesome if both the CLI and the IDE interfaces would ignore lines with the # noqa trailing comment. A minimal example in PyCharm to show that this currently isn't the case is in the screenshot below:

image

Bilbottom avatar Aug 20 '23 11:08 Bilbottom

Hi @Bilbottom! Thank you for this great suggestion, it's definitely something we'll consider.

bm424 avatar Aug 21 '23 09:08 bm424