sourcery icon indicating copy to clipboard operation
sourcery copied to clipboard

When will Sourcery support Apple M1 Silicon?

Open pzelnip opened this issue 3 years ago • 22 comments

Issue description or question

I use Sourcery via the VS Code extension, and while VS Code is now native M1, I noticed that Sourcery still appears in Activity Monitor as an Intel binary requiring Rosetta. Wondering if/when Sourcery will have a M1 native version?

Sourcery Version

VS Code extension version 0.8.7

Code editor or IDE name and version

VS Code

OS name and version

OSX

pzelnip avatar Mar 05 '21 03:03 pzelnip

Sadly this isn't a priority (we also don't have an M1 device to test on) so can't give an answer at the moment.

Hellebore avatar Mar 10 '21 20:03 Hellebore

Hi @pzelnip, could you use sourcery normally except it isn't native supported? As my output of this ext shows an error:

[Error - 12:50:17 PM] Server initialization failed.
  Message: ValueError: RecordCollection contained more than one row. Expects only one row when using RecordCollection.one
  Code: -32602 
[object Object]

megazone87 avatar Mar 18 '21 04:03 megazone87

Seemed to work normally for me via Rosetta, but admittedly until native M1 arrives I have sourcery disabled now in VS Code to save battery.

pzelnip avatar Mar 18 '21 05:03 pzelnip

@songmeixu could you try again with version 0.8.8 and let me know if it works? (we've fixed a similar problem in that version) If not it would be great if you could raise another issue with your details so we can get it sorted out.

Hellebore avatar Mar 19 '21 19:03 Hellebore

@pzelnip Ah I see that's a shame. Will leave this issue open so you can see when we do get native M1.

Hellebore avatar Mar 19 '21 19:03 Hellebore

Sadly this isn't a priority (we also don't have an M1 device to test on) so can't give an answer at the moment.

I don't know why it didn't didn't occur to me to mention this when I first opened the issue, but FWIW I'd absolutely be happy to help with testing Sourcery on my M1-powered Macbook Air (even if not a native M1 version, if there's metrics or data you'd like to collect around how Sourcery runs under Rosetta I'd be willing to help if there's a way I can).

I eventually caved and reinstalled Sourcery on my M1 as I found myself missing the refactorings. I am still a bit worried about the impact on battery life but so far that seems negligible (I did a really unscientific experiment of leaving a VS Code window open with Sourcery installed for about a half hour, made a note of how much the battery drained, then repeated with it not installed and the % drain was about the same).

pzelnip avatar Mar 31 '21 00:03 pzelnip

Came here noticing the same thing when using Sourcery with PyCharm.

Has there been any update since March? Happy to help test.

Depending on how Sourcery is built, hopefully it's a simple matter of enabling cross compilation.

jalaziz avatar Dec 31 '21 02:12 jalaziz

Any updates on the silicon version?

noirchen avatar Jul 23 '22 08:07 noirchen

Works on M1-Pro MBP here.

diceroll123 avatar Jul 23 '22 20:07 diceroll123

I clearly hadn't tried since I first got an M1 but prompting @diceroll123's comment I've just had another play and the vscode extension is working for me on standard M1 chip 😄

paddyroddy avatar Jul 25 '22 08:07 paddyroddy

@paddyroddy the current version works on M1, but is not M1-native -- ie you need Rosetta installed to run it as it's an Intel process, which you can see in Activity Monitor: Screen Shot 2022-07-25 at 11 27 55 AM

The idea of this request is to have a M1-native version of Sourcery so as to not require Rosetta/be more efficient.

pzelnip avatar Jul 25 '22 18:07 pzelnip

Yeah, I get you @pzelnip, but when I first tried (a while ago now) it didn't work even with Rosetta - which is why I've been following this issue

paddyroddy avatar Jul 25 '22 19:07 paddyroddy

Any update on this? We're now multiple years since the launch of Apple Silicon, so it's getting harder and harder to justify running something in Rosetta.

pzelnip avatar Oct 12 '22 06:10 pzelnip

I cannot use Rosetta if VS Code uses a devcontainer that is native arm.

ryanmerolle avatar Oct 18 '22 11:10 ryanmerolle

Hello guys, any update on this? 👀

gquittet avatar Nov 13 '22 18:11 gquittet

Hi, I would love to see this integrated natively. I love Sourcery, but now I'm not using it due to this problem. Any news?

matbmeijer avatar Jan 18 '23 18:01 matbmeijer

I need this, too! I'm using a dev container in VSCode that is native arm.

TheYarin avatar Mar 21 '23 10:03 TheYarin

Hello, is there any update on this?

cmachadomarcos avatar Jun 06 '23 11:06 cmachadomarcos

Need update on this. Please!

chenhuiapp avatar Jul 04 '23 20:07 chenhuiapp

I was able to install Rosetta on my m2 mac and log into Sourcery plug-in. Worked great.

I was able to install Rosetta on my m2 mac and log into Sourcery plug-in. Worked great.

Yes we all can. If you run a devcontainer or docker and it defaults to the normal arm version of a container it does not work because Rosetta cannot run in a vm or container. You can run the container using Rosetta but containers and vms in Rosetta is unbearably slow and resource intensive. Hence the request for native arm support. It would benefit all arm users not just Apple silicon users.

ryanmerolle avatar Jul 21 '23 00:07 ryanmerolle

@Hellebore Is there any ETA on this? I really miss using Sourcery...

gy-mate avatar Mar 20 '24 15:03 gy-mate