action icon indicating copy to clipboard operation
action copied to clipboard

'sourcery-ai/action@v1' doesn't review C sources

Open alexey-tikhonov opened this issue 8 months ago • 0 comments

Hi.

Setup 'sourcery-ai/action@v1' following https://github.com/sourcery-ai/action/tree/main?tab=readme-ov-file#check-your-pr and observed it ignores changes in C sources:

Run git diff 9ae898e5cf5c07278e8e746535777e9f35685391
diff --git a/src/config/SSSDConfigTest.py b/src/config/SSSDConfigTest.py
index e67f47c5e..5d59d32f3 100755
--- a/src/config/SSSDConfigTest.py
+++ b/src/config/SSSDConfigTest.py
... 
diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
index c544bcbe3..6bac4d43e 100644
--- a/src/monitor/monitor.c
+++ b/src/monitor/monitor.c
...
Run sourcery-ai/action@v1
  with:
    token: ***
    diff_ref: 9ae898e5cf5c07278e8e746535777e9f35685391
    target: .
    verbose: true
    check: true
    in_place: false
...
   if [ -n "9ae898e5cf5c07278e8e746535777e9f35685391" ]; then
    SOURCERY_OPTIONS+=( "--diff=git diff 9ae898e5cf5c07278e8e746535777e9f35685391" )
  fi
  
  sourcery review "${SOURCERY_OPTIONS[@]}" .
...
Reviewed src/config/SSSDConfigTest.py

──────── Overview ────────

 • 1 file scanned.                                                              
 • No issues detected.

When run for entire codebase, it also scans only Python sources and ignores C sources. Is this expected?

Note that https://github.com/apps/sourcery-ai handles changes in C sources (example).

alexey-tikhonov avatar May 12 '25 10:05 alexey-tikhonov