hall-of-fame icon indicating copy to clipboard operation
hall-of-fame copied to clipboard

Define custom bots to exclude

Open lyne-bot opened this issue 5 years ago • 4 comments

In fame/github_tracker.py you have some bot-names hardcoded. Would be nice if one could add additional bot-names or other github-account via the gui on sourcerer.

Example-Repo: https://github.com/lyne-design-system/lyne-components

In our case:

  • semantic-release-bot will update the package.json after successfull release, which we would like to exclude from the hall of fame.
  • travis pushes the file DEPLOYMENTS.md back to the repo after a successfull release. It does it with the admin account from our organisation. But no human developer is using that account, so we would like to exclude that one as well.

Do you think that is possible? Or did I miss something in the documentation?

Thank you very much for your efforts yves

lyne-bot avatar Mar 11 '20 14:03 lyne-bot

Hi @lyne-admin ,

As a temp measure, I can accept a PR that blacklists your bots:

image

https://github.com/sourcerer-io/hall-of-fame/blob/develop/fame/github_tracker.py

sergey48k avatar Mar 11 '20 21:03 sergey48k

Hi @sergey48k Thanks for your answer. I created a pull-request: https://github.com/sourcerer-io/hall-of-fame/pull/44

feerglas avatar Mar 12 '20 14:03 feerglas

@feerglas : I merged your request (thanks!), will push it to prod in the couple of days. Will ping you here once it's done.

sergey48k avatar Mar 13 '20 04:03 sergey48k

@sergey48k thank you very much, appreciate it!

feerglas avatar Mar 13 '20 09:03 feerglas