syntect_server icon indicating copy to clipboard operation
syntect_server copied to clipboard

Published 20 hours ago • verified publisher icon sourcegraph

upstream additions to syntect

Open emidoots opened this issue 8 years ago • 3 comments

The ./syntect folder is a copied / slightly modified version of upstream syntect. I should figure out the correct way to send these changes upstream.

  • [ ] TypeScript + TypeScriptReact syntaxes: https://github.com/slimsag/Packages/commit/7a886e64de1d937bd03ad12466813f93ad9079e3

  • [ ] Swift syntax: https://github.com/slimsag/Packages/commit/2048b5c986f7ffc64cf7b9de158fabd97c38b08f

  • [ ] Replace default JavaScript syntax with babel-sublime (better support for e.g. jsx files etc) https://github.com/slimsag/Packages/commit/d1c60895c4c5f42fc12d6684009a4b73330027b0 and https://github.com/slimsag/Packages/commit/3c2a649c821a38af967f0390bccb04c46c444174

  • [ ] Visual Studio Dark theme: https://github.com/slimsag/syntect/commit/304c6089014b7fdf9c727c0a49b336b2db4452a4

  • [ ] Visual Studio (plain) theme: https://github.com/slimsag/syntect/commit/9521fa752561427c9d03471a39da3274df03d806

  • [ ] Monokai theme: https://github.com/slimsag/syntect/commit/579eb4471f2736a6d3f0bdb25aeadb48963d1016

  • [ ] TypeScript themes: https://github.com/slimsag/syntect/commit/b62d6c55e771b0f97376cae465629e62fc7ca581

EDIT: there is now much more changes in terms of Packages etc. than just the above that we would want to send upstream^

emidoots avatar Aug 28 '17 19:08 emidoots

Hey! Saw that you're planning to contribute syntaxes to syntect.

syntect is currently using the definitions from sublimehq/Packages, and I don't think we'd want to start maintaining a non-trivial fork of those. If you could contribute them there instead, that would be really cool. It would mean not only syntect but also Sublime Text would benefit.

(CC @trishume and @keith-hall, which might be able to help upstream them)

robinst avatar Aug 29 '17 04:08 robinst

@robinst Very good point, the syntaxes should be upstreamed to that repo. Thanks for mentioning!

(The themes would still be upstreamed to Syntect, though, since AFAIK there is no standard repo for Sublime themes which Syntect could pull from).

emidoots avatar Aug 29 '17 05:08 emidoots

I don't think SublimeHQ have any plans ATM to include a TypeScript package with Sublime Text, so that would probably not be accepted (especially if it contains performance reducing features like lookbehinds), but JSX and Swift are desired: https://github.com/sublimehq/Packages/issues/860 and https://github.com/sublimehq/Packages/pull/11

Maybe a better approach (to allow the use of any syntax definitions, regardless of desirability in ST's main repo) would be to have a git repo with submodules that would link to the official packages repo, and other syntax definition repos and use that with syntect?

keith-hall avatar Aug 29 '17 05:08 keith-hall