src-cli icon indicating copy to clipboard operation
src-cli copied to clipboard

src extensions publish does not work correctly on Windows

Open felixfbecker opened this issue 5 years ago • 0 comments

https://github.com/sourcegraph/src-cli/blob/4e548d9ca9a9a4316bf4692773f44bd19f5386dc/cmd/src/extensions_publish.go#L174

The expected behaviour here would be what npm does, which is using cmd on Windows. This decision is automatically made by Node child_process.exec().

https://github.com/sourcegraph/src-cli/blob/4e548d9ca9a9a4316bf4692773f44bd19f5386dc/cmd/src/extensions_publish.go#L175

Windows uses ; to separate PATH, not :.

felixfbecker avatar Sep 29 '18 10:09 felixfbecker