sourcegraph icon indicating copy to clipboard operation
sourcegraph copied to clipboard

searcher: replace usage of gitserver.DiffSymbols with new gitserver.ChangedFiles client method

Open ggilmore opened this issue 9 months ago • 1 comments

Part of https://github.com/sourcegraph/sourcegraph/issues/60654

This PR replaces hybrid's search use of the gitserver.DiffSymbols endpoint with the new gitserver.ChangedFiles gRPC endpoint introduced in https://github.com/sourcegraph/sourcegraph/pull/62354.

Test plan

Existing CI pipeline

ggilmore avatar May 01 '24 20:05 ggilmore

  • #62363 Graphite
  • #62360 Graphite
  • #62359 Graphite
  • #62358 Graphite 👈
  • #62355 Graphite
  • #62354 Graphite
  • #62262 Graphite
  • #62252 Graphite
  • #62217 Graphite
  • #62216 Graphite
  • #62212 Graphite
  • #62302 Graphite
  • #62173 Graphite
  • #62169 Graphite
  • #62165 Graphite
  • #62158 Graphite
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

ggilmore avatar May 01 '24 20:05 ggilmore

Ad gif. Man with a beard and a plaid button up shirt stands next to a rocky river in the wilderness. He looks at us with a smug smile, holding a Busch beer in one hand, giving a big thumbs up with the other. (Added via Giphy)

graphite-app[bot] avatar May 02 '24 15:05 graphite-app[bot]

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (05/02/24)

1 gif was posted to this PR based on Geoffrey Gilmore's automation.

"Auto-assign PRs to author" took an action on this PR • (05/06/24)

3 assignees were added to this PR based on Geoffrey Gilmore's automation.

graphite-app[bot] avatar May 02 '24 15:05 graphite-app[bot]

meta: github does a really bad job with all these graphite updates. The actual review comments all get hidden away with the inconsiquential updates on force-pushes.

keegancsmith avatar May 07 '24 08:05 keegancsmith

Merge activity

  • May 7, 2:10 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 7, 2:20 PM EDT: @ggilmore merged this pull request with Graphite.

ggilmore avatar May 07 '24 18:05 ggilmore