lsif-go icon indicating copy to clipboard operation
lsif-go copied to clipboard

remote implementations are not linked for method calls

Open tjdevries opened this issue 4 years ago • 0 comments

I'll probably work on this next, but it is not a blocking issue to ship implementations, IMO

Some example tests:

	t.Run("remote_implementations: finuds implementations in signature", func(t *testing.T) {
		r := mustRange(t, w, "file://"+filepath.Join(projectRoot, "implementations_remote.go"), 10, 38)

		monikers := findMonikersByRangeOrReferenceResultID(w, r.ID)
		t.Fatalf("%+v\n", monikers)
	})

	t.Run("remote_implementations: finds implementations on method call", func(t *testing.T) {
		r := mustRange(t, w, "file://"+filepath.Join(projectRoot, "implementations_remote.go"), 11, 12)

		// assertRanges(
		// 	t,
		// 	w,
		// 	findImplementationRangesByRangeOrResultSetID(w, r.ID),
		// 	[]string{"4:5-4:21"},
		// 	"ResponseWriter Implementation (from signature)",
		// )

		monikers := findMonikersByRangeOrReferenceResultID(w, r.ID)
		t.Fatalf("%+v\n", monikers)
	})

tjdevries avatar Nov 04 '21 19:11 tjdevries