go-langserver Windows support

We have file path issues all over the place. We also have some in-progress work to sort this all out by @alexsaveliev. https://github.com/sourcegraph/go-langserver/pull/86 https://github.com/sourcegraph/go-langserver/pull/79

Jan 25 '17 12:01 keegancsmith

+1 windows support needed

Mar 30 '17 00:03 ghost

👍

Apr 06 '17 16:04 suriyaa

I see several Windows PRs merged. Is this issue still relevant?

Jul 25 '18 13:07 levrik

In theory it is working, we are running a windows based CI and the tests pass. Can you try the language server out on windows and tell me if it works? I don't have access to a windows machine.

Jul 25 '18 13:07 keegancsmith

@keegancsmith This is great news. I gave this a try today from VS Code and found the below:

Hover, Go to definition, Format, Auto-completion works
References and Signature Help both fail with "import "/c:/GoCode/src/github.com/golang/example/hello": cannot import absolute path"
Workspace symbol search returns empty results, no error

Aug 22 '18 01:08 ramya-rao-a

Repeating my comment here, I tested this using VSCode on Windows and everything worked except for Find References:

Find References works but suffers from the same problem as guru on Windows: searching for references of a symbol at the definition site of the symbol only finds references in the same package but searching for references from a usage site of the symbol outside of its package finds all references in all packages.

Oct 31 '18 14:10 doxxx

Thanks @doxxx! I can confirm the same.

Oct 31 '18 17:10 ramya-rao-a

FYI, I have submitted a PR fixing the Find References bug on Windows in guru that I mentioned earlier: https://github.com/golang/tools/pull/56

I tried searching the go-langserver code to see if the same fix was trivially applicable but I was not successful.

Jan 11 '19 16:01 doxxx