conc icon indicating copy to clipboard operation
conc copied to clipboard
verified publisher icon sourcegraph

iter-err: add ForEachErr and ForEachIdxErr

Open ninedraft opened this issue 2 years ago • 5 comments

Adding error returning iterators

ninedraft avatar Mar 14 '23 17:03 ninedraft

Fixed linter issues

ninedraft avatar Mar 15 '23 11:03 ninedraft

Codecov Report

Merging #104 (8bde958) into main (8e5ba59) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   99.30%   99.36%   +0.05%     
==========================================
  Files          12       12              
  Lines         433      474      +41     
==========================================
+ Hits          430      471      +41     
  Misses          3        3
Impacted Files Coverage Δ
iter/iter.go 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jun 01 '23 16:06 codecov-commenter

We should probably make Mapper respect the FailFast flag as well since we already have a MapErr and we don't want that to have different behavior.

camdencheek avatar Jun 01 '23 18:06 camdencheek

Is this still on the radar?

justenstall avatar Apr 05 '24 18:04 justenstall

Yeah, I will refine the pr

ninedraft avatar Apr 05 '24 19:04 ninedraft