sourcegraph
do not block on CodyLLMSiteConfiguration (configOverwrites) fetch in initial auth
To authenticate a user and start showing the UI, we actually don't need to
fetch the CodyLLMSiteConfiguration (configOverwrites). This reduces the
number of HTTP requests (albeit they were parallelized somewhat) needed
before the user can be authenticated and start seeing the Cody UI.
This uncovered some possible "bugs" in the anthropic.test.ts autocomplete
tests, where they were asserting that the model would be set but it
actually would not be in real life. In Provider.maybeFilterOutModel it
sees that this.configOverwrites?.provider === 'sourcegraph' in the test,
but that should not be true in real life because it’s being passed an
authStatus that is non-dotcom. The reason the test is bad is because that
method gets the auth status from currentAuthStatus(), which is dotcom in
testing only because of a prior test's mock value.
- do not block on fetching the user's Cody Pro subscription status when authing
Test plan
CI & e2e. Sign in and ensure that operation that need the site version (such as autocomplete) still function without an error.
Changelog
- Made authentication faster and less prone to network instability by reducing the number of HTTP requests needed for authentication.
