browser-extensions icon indicating copy to clipboard operation
browser-extensions copied to clipboard

chore: run TSLint on all folders

Open felixfbecker opened this issue 7 years ago • 6 comments

Closes #64

To fix:

ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/chrome/extension/background.tsx[114, 1]: Promises must be handled appropriately
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/chrome/extension/background.tsx[268, 5]: Promises must be handled appropriately
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/chrome/extension/background.tsx[276, 5]: Promises must be handled appropriately
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/chrome/extension/background.tsx[321, 5]: Promises must be handled appropriately
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/extension/safari/StorageArea.ts[65, 40]: Explicit type parameter needs to be provided to the constructor
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/extension/storage.ts[91, 40]: Avoid referencing unbound methods which may cause unintentional scoping of 'this'.
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/extension/storage.ts[91, 50]: Avoid referencing unbound methods which may cause unintentional scoping of 'this'.

felixfbecker avatar Aug 20 '18 19:08 felixfbecker

@ijsnow can you confirm TSLint is now run on all folders?

felixfbecker avatar Oct 03 '18 20:10 felixfbecker

@felixfbecker https://sourcegraph.com/github.com/sourcegraph/browser-extensions@master/-/blob/package.json?diff=ffb64d67db79b099c7879353fdaebfbf2b06194a&utm_source=firefox-extension#L14

ijsnow avatar Oct 03 '18 20:10 ijsnow

So that is a no

felixfbecker avatar Oct 03 '18 20:10 felixfbecker

It's ran on all code that is ran by the browser extension

ijsnow avatar Oct 03 '18 21:10 ijsnow

Tests in cypress/, the webpack configs in webpack/ and the scripts in scripts/ are all TypeScript and should be linted too

felixfbecker avatar Oct 03 '18 21:10 felixfbecker

Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions

cd browser-extensions
git format-patch master --stdout > /tmp/patch

cd ../sourcegraph
cat /tmp/patch | git am -3 --directory=packages/browser-extensions/
# and fixup merge conflicts

chrismwendt avatar Nov 05 '18 03:11 chrismwendt