appdash icon indicating copy to clipboard operation
appdash copied to clipboard

Add important event support to the OpenTracing impl

Open bg451 opened this issue 8 years ago • 1 comments

It would be nice to be able to add important annotations via the opentracing API.

I haven't spent much time thinking about it, but it would work by prefixing a tag's key, i.e. span.SetTag("impt:status", resp.StatusCode). This would add an important annotation with key="status".

bg451 avatar Apr 04 '16 22:04 bg451

Highly agreed, this would be very nice. In another aspect, for the storage backend, one could imagine filtering (indexing) based on 'important' tags like URL route, so that you could search for traces by URL route for example.

I wonder if the distinction between 'important tags' and 'tags' (or 'verbose tags') is a distinction that would be useful to others in the OpenTracing API.. or if it is really only applicable to Appdash? Will need to do some investigation / start up some discussion over there to find out, I guess.

emidoots avatar Apr 05 '16 17:04 emidoots