sourcegit icon indicating copy to clipboard operation
sourcegit copied to clipboard

Unify how the Workspaces and Tabs dropdowns/popups work

Open goran-w opened this issue 2 months ago • 5 comments

The top-bar buttons (and keyboard shortcuts) for Workspaces (Ctrl+Shift+P) and Tabs (Ctrl+P) are great features, but they would benefit from some further improvements and unification to make them more similar and consistent:

  • The Workspaces button opens a dropdown menu immediately below the button, while the Tabs button opens a popup in the center of the main window. In contrast, the keyboard shortcuts for both of these features open a centered popup. However, IMHO the most user-friendly option would be to use a drop-down when pressing a button while using a centered popup when pressing a keyboard shortcut!
  • The Tabs feature shows the same panel regardless of how we activate it. In contrast, the Workspaces drop-down panel differs from its corresponding popup panel despite the displayed shortcut making the user think they would be identical (which they should, IMHO - they should only differ in positioning when the panel is opened by button/drop-down vs shortcut/popup).
  • The Tabs button displays its shortcut in a tooltip directly on the button itself (good!), while the Workspaces button displays it only inside the drop-down (not so good).
  • The Workspaces drop-down has a "Configure Workspaces..." option that allows us to (most importantly) create a new workspace. This option should be retained when opened by shortcut/popup, and then the panel could be the same in both cases!
  • The Tabs drop-down/popup is currently missing a "(Create) New Tab" option (or similar). This option would do the same as the "+" button in the tab bar - but we should NOT have to escape the drop-down/popup to seek out the "+" button, if we realize that the tab we really wanted was not in the list after all but would need to be added as a new tab instead... This would also make the Tabs feature more complete and more consistent/similar to the Workspaces feature.

goran-w avatar Oct 16 '25 08:10 goran-w

Actually, I'm considering removing the shortcut function for switching between workspaces (include the workspace switcher popup). The dropdown menu of workspaces button will be remained.

Ctrl+Shift+P will be changed to open a command panel similar to the VSCode Command Palette. I'm still thinking about it. No changes will be made for the time being.

love-linger avatar Oct 16 '25 09:10 love-linger

After this change, how can we switch workspaces via keyboard? (If not, it's a sad downgrade of usability.)

goran-w avatar Oct 16 '25 13:10 goran-w

Yes. As I said above, the hotkey has been also removed and there's no plan to support it any longer.

love-linger avatar Oct 16 '25 13:10 love-linger

What do you mean - why would you not support a shortcut for Workspace switching any longer? I use several Workspaces, with several repo-tabs in each, and I switch between these Workspaces frequently. Having to do this only via mouse is not convenient in the long run.

I understand your motive of using the previous shortcut Ctrl+Shift+P for a command palette, since it would then match the shortcut in VS Code.

But then PLEASE add ANOTHER (new) keyboard shortcut (like Ctrl+Alt+P) for switching Workspaces (instead of removing the shortcut altogether)!

goran-w avatar Oct 16 '25 14:10 goran-w

Related commits: 8846bfe4a7fe4b08b62b1f6be7f027dc44e652f9, 0b4be6e22630df98d56674a774ec17bea76203f1

The new shortcut for switching workspaces is now Ctrl+Alt+P and it's listed in the tooltip directly on the button. Also, the shortcurt now opens the dropdown instead of the centered switcher. Thanks, @love-linger, this is better!

What could still be improved is to make the Tabs switcher display as a dropdown (instead of centered) when pressing the associated button (and possibly its shortcut too), just like the Workspace switcher does. (Because currently there's an inconsistency between how the two similar switcher buttons, which are located next to each other, display their panels.)

goran-w avatar Oct 20 '25 08:10 goran-w