[Enhancement] Use 'cloud' icon to distinguish remote branches in context menus

[goran-w]

For consistency and distinction, the icon used for remote branches in the (HISTORY) log-graph context-menu should be the 'cloud' icon instead of the 'branch' icon.

See this screenshot, where two different icons are used for the same (remote) branch:

[goran-w]

Why not-planned? IMHO it's quite inconsistent to use different icons for the same (remote) branch - which becomes very apparent in my screenshot above?

[goran-w]

When opening the context menu there, it would be easier to match its list of branches (against the branch-badges on the selected row) if the icons were matching... (I find this visual discrepancy confusing.)

[goran-w]

This (mockup) would IMHO make much more sense, visually... (Maybe even replicate the 'checked' icon, indicating the current branch?)

[love-linger]

I do not think so. In this app, the Icons.Remote only used for remote branch in commit graph (in order to distinguish remote branches from the local branches easily, since they are grouped together only here).

In other places, the Icons.Remote should only used for remote not remote branch.

[love-linger]

And in the context menu of selected commit, the first group is about branch functions. I do not think it is inconsistent

[goran-w]

in order to distinguish remote branches from the local branches easily, since they are grouped together only here

The exact same reasoning should be used in the first group of the context menu, where the same branches are grouped together in the same way (only vertically instead of horizontally)!

It's a missed opportunity, to NOT help the user distinguish these in the very same way.

[goran-w]

Look at this example... 4 branches with 4 icons, grouped horizontally and vertically.

Same ordering, same grouping, only the icons are inconsistent between the two groups.

There are 3 different branch variants possible :

• Current local branch (Icons.Head)
• (Other) local branch (Icons.Branch)
• Remote branch (Icons.Remote)

For each of these 3 variants, the corresponding context sub-menus have different contents - yet another reason to distinguish them more explicitly in the context menu as well. (I don't see why we should NOT provide this extra help to the user - it will be quicker to determine which one of the grouped branch sub-menus to expand, if they can be more easily distinguished.)

(NOTE: Tags are grouped separately in context menu and not relevant here, but they are distinguished by their Icons.Tag.)

[goran-w]

Here's a mockup of how I'd like the branch-grouping to look in that context menu :

Note how the context menu icons (and styling) are now consistent with the corresponding horizontal grouping on the selected row. (I also added a tag, to show that second grouping as well, which means all the possible icon-variants are now in this screenshot.)

DISCLAIMER: If this type of colorful rendering of the "current local branch" is deemed "too extreme" for a context menu, we could skip the colored background and use just the Icons.Head checkmark. (However, I actually like the splash of color which indicates that this branch is - currently - a special one...)