sourcecred
sourcecred copied to clipboard
GitHub PR review comments rewarding duplicate cred
In the GitHub plugin, we give cred to anyone that's reviews a PR. However, in GitHub's data model, each comment on a PR review counts as a unique "review" object, with the exception of a review where the comments are published together when clicking "Start a Review" instead of "Add Single Comment". This causes a lot more cred to be minted for reviewing PR's than intended.
This needs to be fixed by making sure multiple review comments dont generate additional cred and we create only a single "review" node for each person that reviewed.
┆Issue is synchronized with this Asana task by Unito
@hammadj just to clarify, if someone provides 2 cycles of full reviews on a PR, they should get cred for both of those reviews, correct?
We don't want cred capped at 1 review per PR.
Maybe we could count each Review as a node, and all non-Review comments together as 1 node? Not sure how the GH api data is structured.
Also someone from maker has noticed this problem too.
To clarify the language a bit from my experience, I ran across this when I created ~40 suggestion
comments on a pull request to allow the original author to fix a systemic formatting error quickly. (GitHub can collect and apply suggestion
s.)
In my case, each of the suggestions shows as a comment
rather than a review
as suggested in the initial report. The issue of them conferring essentially unbounded cred, however, is still present.