Hack icon indicating copy to clipboard operation
Hack copied to clipboard

linux installation instructions outdated ?

Open jorgheymans opened this issue 6 years ago • 6 comments

the instructions mention to

  • Copy the font configuration file in config/fontconfig/ to either the system font configuration folder (often /etc/fonts/conf.d/) or the font user folder (often ~/.config/fontconfig/conf.d)

but there is no config/fontconfig in the provided archive. I'm on Ubuntu, should i look for another way to install the font ?

jorgheymans avatar Jun 21 '18 14:06 jorgheymans

It is located in the repository on the path https://github.com/source-foundry/Hack/blob/master/config/fontconfig/45-Hack.conf

Perhaps we could add this as an option to the linux installer script? The archives are prepared for cross-platform use.

chrissimpkins avatar Jun 21 '18 14:06 chrissimpkins

Though I suppose it wouldn't be a tremendous issue to add a directory with the file to the compressed release archives or push this as a separate file in our releases. Thoughts?

chrissimpkins avatar Jun 21 '18 14:06 chrissimpkins

i think the easiest would be to adjust the wording of the documentation and point to the full URI of the fontconfig file in the git repo, no ambiguity. Still, it's funny to grab a config file from master together with a tagged release. It implies that the config file is valid for all versions, not saying that's an issue just pointing it out :)

jorgheymans avatar Jun 21 '18 21:06 jorgheymans

That file was a PR in to the project and my understanding is that it is valid for all versions, past and future. Will update docs. Thanks for pointing it out Jorg. Appreciate it.

chrissimpkins avatar Jun 21 '18 21:06 chrissimpkins

Thanks Chris. Just noticed there is https://github.com/source-foundry/hack-linux-installer as well so i used that, it worked fine. It would make sense to mention it on the main installation page I think https://github.com/source-foundry/Hack#quick-installation , just like the windows installer is mentioned there. The 'manual' installation instructions would just be a fallback then for those that don't want to use the script.

jorgheymans avatar Jun 22 '18 08:06 jorgheymans

Thank you!

chrissimpkins avatar Jun 22 '18 11:06 chrissimpkins