frontend
frontend copied to clipboard
source-academy
Decouple Playground from SICP Workspace
Description
The tight coupling is blocking a couple planned changes related to refactoring to make use of language configs.
Fixes #2410.
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
- [x] Code quality improvements
How to test
Checklist
- [x] I have tested this code
- [ ] I have updated the documentation
Pull Request Test Coverage Report for Build 5010569236
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 2 of 237 (0.84%) changed or added relevant lines in 2 files are covered.
- 68 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.6%) to 34.197%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/pages/playground/Playground.tsx | 0 | 1 | 0.0% |
| src/pages/sicp/subcomponents/SicpWorkspace.tsx | 2 | 236 | 0.85% |
| <!-- | Total: | 2 | 237 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| src/pages/playground/Playground.tsx | 68 | 1.94% |
| <!-- | Total: | 68 |
| Totals | |
|---|---|
| Change from base Build 5010320171: | -0.6% |
| Covered Lines: | 4916 |
| Relevant Lines: | 13400 |
💛 - Coveralls
This PR will first require the language config object to be moved from a hardcoded Playground state to be under the workspace context instead. Currently, the SICP Workspace still inherits and affects the state of the Playground, so this should not be merged yet.
This PR will first require the language config object to be moved from a hardcoded Playground state to be under the workspace context instead. Currently, the SICP Workspace still inherits and affects the state of the Playground, so this should not be merged yet.
The overall direction of this PR looks good. I'll look through the final version of this PR thoroughly since it's mostly checking that the workspaces are separated correctly.
