frontend icon indicating copy to clipboard operation
frontend copied to clipboard

SideContentTab.id should not be optional

Open chownces opened this issue 3 years ago • 0 comments

The mobile workspace uses these IDs to track the currently selected tab, and renders the corresponding panel. Not specifying the ID would result in an empty panel being rendered.

src/commons/sideContent/SideContentTypes.ts

export type SideContentTab = {
  label: string;
  iconName: IconName;
  body: JSX.Element;
  toSpawn: (context: DebuggerContext) => boolean;
  id?: SideContentType;
  disabled?: boolean;
};

To also check if importing multiple modules would be affected, since they are all attached the SideContentType.module id, which is not unique (see SideContentHelper.ts)

chownces avatar May 15 '21 11:05 chownces