Results 24 comments of Souradeep Das

Continuing the discussion from https://github.com/omisego/elixir-omg/issues/1426 - Summing up the discussions with @unnawut - - A lot of duplicate events show up in datadog i.e. events about the same activity with...

Hey @T-Dnzt, So we are getting rid of [this test](https://github.com/omisego/elixir-omg/blob/master/apps/omg_watcher_rpc/test/omg_watcher_rpc/web/controllers/transaction_test.exs#L1237-L1267) since the transaction is no more created after the earlier detection?

@unnawut Almost, reviewing all the changes myself and then requesting for your reviews.

Also @pnowosie asking for a re-review to confirm the latest changes. Thanks :bow:

@unnawut do we need to update any env vars?

Hey @InoMurko! Thanks for the review :bow: So, `eth_timestamp_now` is mostly storing the `timestamp ( eth_height_now )` replacing `eth_height_now` we had previously. Previously we had - late_invalid_exits = Enum.filter(invalid_exits, fn...

Do we need a successive change for the change in API endpoint? @InoMurko @unnawut @T-Dnzt

What values do we do for `EXIT_PROCESSOR_SLA_SECONDS` for docker-compose

But isn't `MIN_EXIT_PERIOD_SECONDS` in seconds ?

Some thoughts- 1) "not in market" is a good idea imo. I think for withdrawals we can however allow people to withdraw as long as the pool can suffice, instead...