Sourab Pramanik

Results 85 comments of Sourab Pramanik

> Hope you don't mind, I pushed a small commit adding the adapter to the `turbo.json` turborepo config and updated the `pnpm-lock.yaml` with the appwrite-adapter package and dependencies. > >...

For the get remaining API, do you guys have any suggestions for the implementation? I am trying to figure out a way where every algorithm will have their own method...

@ogzhanolguncu @enesakar These are my proposed changes, the implementation of the algorithm does not change just that I have changed the Algorithm function return signature so that we can add...

The signature doesn't have to be like this it can work like it used to do by providing the limiter function. I will refactor this

> ``` > const ratelimit = new Ratelimit({ > redis: kv, > limiter: {getRemaining: _,limit: _}, > }); > ``` > > Why do we expose `getRemaining` and `limit` to...

> ``` > const ratelimit = new Ratelimit({ > redis: kv, > limiter: {getRemaining: _,limit: _}, > }); > ``` > > Why do we expose `getRemaining` and `limit` to...

> Thanks a lot for the changes! I think the changes look good overall. I only made a small fix in [4c9002d](https://github.com/upstash/ratelimit/pull/84/commits/4c9002df5aba9e74ee75ca75c9cec950ae306da6). Thanks @CahidArda

> I feel like we can leave [the discussion about changing the API](https://github.com/upstash/ratelimit/pull/84#discussion_r1554017760) for another time. Yes I believe we can create a new issue for the same and discuss...

@off99555 I am not sure about your use case but if you do it like this to get the remaining limit: ```typescript const { remaining } = await ratelimitFree.limit( "someUniqueIdentifier"...

> @sourabpramanik That isn't ideal because I want to check remaining values often without modifying the limit. For example, I might want to display this remaining vaue on every page...