react-media-player
react-media-player copied to clipboard
Roadmap
Roadmap
- [ ] Multiple sources support
- [ ] Show time/thumbnail preview when hovering Seekbar
- [ ] Subtitle support
- [ ] Playback speed option
- [x] Keyboard friendly
- [ ] ARIA a11y ready
- [ ] Move controls into addons
- [ ] Add tests
- [ ] Add SoundCloud API support
- [ ] Allow people to add their own vendors by passing vendor components through props
- [ ] Allow people to only include code for the vendors they need
Inspiration
http://terrillthompson.com/blog/32 https://wistia.com/doc/viewer-requirements
Supporting events (like onMute
, onPause
, OnStart
, onSeek
) would be useful. Thanks for this great lib!
In favor of keeping the library small and not having to code that for each vendor I figured it could be achieved in componentDidUpdate
with something like the following:
componentDidUpdate(lastProps) {
if (lastProps.isMuted !== this.props.isMuted) {
// handle onMute
}
}
does that work for you?
That's better indeed. Any way to watch when seekTo
is called, at least from inside the SeekBar
(to use instead of onSeek
)?
I think currentTime
would be your best bet.
componentDidUpdate(lastProps) {
if (lastProps.currentTime !== this.props.currentTime) {
// handle onSeek
}
}
Please let me know if that works or not.
Thanks! I thought currentTime
is synchronised during the video playing, but it appears to be as startingTime
, so it will work for sure.
yeah! looking forward to see soundcloud integration. thx 4 this lib
@zalmoxisus implemented actual callbacks in the latest release 🎉 https://github.com/souporserious/react-media-player#onplay-proptypesfunc
@souporserious Any plans to add demo link (github-pages, or codepen)? It would be great to be able to see the functionality in action from the repo itself!
Yes, I totally agree. Just been slammed with work lately. I will have live demos up soon! For now you can pull the repo and run the demos yourself. Definitely not ideal, but works for now.
Hey, This is super useful. I'd love to contribute support for more audio file formats but have no idea if that's within reach. Could someone point me to the right docs about html5 audio formats and I'll see what I can do? Thanks
Thanks @talolard. I'd love to help you get onboard. If you can give me a week or two, I'll have better documentation for everything so contributing will be easier. Are there any file formats you found that don't work with the current player?
Any plans to upgrade to react 16.3 with new Context API?
Yes! Sorry this has been a little stale. I plan to do an update and finish this as soon as I get some free time 😅.
Hi @souporserious, any updates when the new context api changes will be released?
Sorry, no solid timeline right now 😞. I'm wrapping up a few other projects that I've been consumed with, but once they are done I'll hop on here and get it done.