get-node-dimensions

get-node-dimensions copied to clipboard

Cloning media elementes leads to additional network requests

1

I noticed this issue when I was using `react-measure` on a piece of DOM that contained a video tag with `preload` attribute set to `"auto"`. During an animation, `getNodeDimensions` was...

tf

Is there any way you can provide a scroll aware modification? For example, if you get the element's `top`, you get 200. If you scroll down, the `top` returned is...

NHuebner1983

yarn.lock updated and gitignoring because node10 conflicts///

ibyteyou

I ended up doing this directly in React Measure on a rewrite. [This file](https://github.com/souporserious/react-measure/blob/master/src/get-content-rect.js) should essentially be ported over to here when I get the chance.

souporserious

Came across [this library](https://github.com/davidtheclark/jquery.cssAnimateAuto/blob/master/src/jquery.cssAnimateAuto.js#L80) and they might be doing something better. Need to look into it.

souporserious

Cloning elements is removing decimals

1

Currently when an element is not cloned, it's using the actual width including decimal points. But when cloning it's rounding. I believe the first option is more correct: https://github.com/souporserious/get-node-dimensions/blob/master/src/get-node-dimensions.js#L24-L25 I...

bookman25