soundscape icon indicating copy to clipboard operation
soundscape copied to clipboard

Add functionality to repeat last callout upon shaking device + RCOS Documentation

Open connorhakan8 opened this issue 1 year ago • 3 comments

connorhakan8 avatar May 10 '24 06:05 connorhakan8

Hi. Thanks for working on this! It still needs quite a bit of clean up though; there are remnants of previous attempts, commented sections of code, whitespace changes in unrelated files etc.

I also think a setting to optionally enable this is essential. It can be very easy to trigger a shake action by mistake especially when moving around.

Please don't be discouraged by this comment - we really appreciate your work on this. Your notes are an interesting read and clarify some things which aren't well explained in the existing documentation.

RDMurray avatar May 13 '24 17:05 RDMurray

For many of the changes, I don't know how they came to fruition (things like the changes in Packages.resolved, Map.storyboard, and exclamation marks added to a few of the files). Maybe they somehow got added when I pulled the branch (I remember way back when starting this project that there were a few compilation errors due to running this on a newer version of XCode, so maybe they got added there?). I wonder if these changes should be reverted or not before pulling this. And I'll work on removing the extraneous information - they generally seem to be things I missed in my first run-through of cleaning up the program.

connorhakan8 avatar Aug 01 '24 22:08 connorhakan8

Here's the new commit. It should be virtually ready to be pulled (after resolving the issues listed above). Another thing: I question how the "allow callouts" toggle actually works. It seems like all the buttons below are functional when callouts are disabled. My code that supports shaking the device to repeat the last callout also still works. If you know how this toggle is supposed to work, please reply down here and I can make changes accordingly.

connorhakan8 avatar Aug 02 '24 00:08 connorhakan8

Finally merged! Thanks for tackling this.

steinbro avatar Sep 15 '24 12:09 steinbro