barista
barista copied to clipboard
soumya92
Handle xesam:albumArtist being a string and not an array
Got tripped up by this when using https://github.com/Sinono3/souvlaki through https://github.com/jpochyla/psst.
It uses xesam:albumArtist instead of xesam:artist and the xesam:albumArtist is a String, not Array, so we should probably handle that, even if it's not convention.
Added a basic test for string vs array. Probably not the best way of doing it, but it works.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
I wonder if maybe the better PR would be to just change https://github.com/Sinono3/souvlaki/blob/287797cd926fd7be802d5310fcc3836b0f5bc556/src/platform/linux/mod.rs#L303 :smiley:
From my somewhat limited experience, most players are not quite adhering to the spec. But I agree that the proper way would be to change Souvlaki here.
Okay, if its more than just this one, let's make the change. Can you also do the same for artist just to be consistent? Other than that this looks good to me.