firebase-mock icon indicating copy to clipboard operation
firebase-mock copied to clipboard

Incorrect Bucket File download Api

Open hadson19 opened this issue 5 years ago • 1 comments

I've looked into the code Firebase Bucket Storage File (firebase-admin: "8.3.0") and found that when we call download - the content should be returned in any case..

  export declare type DownloadResponse = [Buffer];
  export declare type DownloadCallback = (err: RequestError | null, contents: Buffer) => void;

What do you think about this? Thanks.

hadson19 avatar Nov 21 '19 17:11 hadson19

Should be fixed bu pull request https://github.com/soumak77/firebase-mock/pull/128/files

hadson19 avatar Nov 21 '19 17:11 hadson19