firebase-mock icon indicating copy to clipboard operation
firebase-mock copied to clipboard

Ignore ReadOptions on getAll

Open op opened this issue 5 years ago • 1 comments

This change ignores the optional ReadOptions in firestore.getAll. It also raises an exception if no argument were passed at all.

If you use the firebase-admin package and call getAll with only one argument; ReadOptions -- it will actually do the round-trip to the backend. If you have no arguments at all, it raises an exception and no promise is created. This behaviour is also mimicked.

The first argument is required and must be of type DocumentReference followed by any additional DocumentReference documents. If used, the optional ReadOptions must be the last argument.

References: https://cloud.google.com/nodejs/docs/reference/firestore/latest/Firestore#getAll

op avatar Mar 01 '19 19:03 op

Conversation continuing here (see #160)

dmurvihill avatar Nov 19 '19 19:11 dmurvihill