soulomoon

Results 104 comments of soulomoon

1. the syntax color part. Seems the `do` is missing color. It should be syntax highlighting problem. Since HLS does not provide the syntax highlighting, it is not a problem...

> Absolutely! I am working on a prototype for basically all the things you are describing right now. > > Slightly unintended side effect is, that we need to re-invent...

* [x] I found hls-class-plugin-test unconditionaly waited for 5 second for each test. swtich `waitForDiagnosticsFromSource` to `waitForDiagnosticsFrom` clear fix it, I am going to do it. #4059

`waitForDiagnosticsWithSource` wait for 5 seonds unconditionally. We should avoid using it or fix it up eliminate the unconditional wait.

> Would it be possible to have sort of incremental option where HLS first build `open-files` then if everything is ok, builds `current-component` and so on until everything is built?...

It is related to ghc giving unwanted suggestions: https://gitlab.haskell.org/ghc/ghc/-/issues/23982 and https://gitlab.haskell.org/ghc/ghc/-/issues/18740

The current codeActions use regex to parse the result which is a mess. It might be easily fixed when using GHC's structured diagnostics https://github.com/haskell/haskell-language-server/issues/2014

It looks cool, 🤔 how is the result sorted, should we sort the result?

> Doesn't the GHCSession action takes care of this? Perhaps we are not taking care of things that is not used yet, you can dig deeper to see how do...