FF-ULTIMA icon indicating copy to clipboard operation
FF-ULTIMA copied to clipboard

support to toggle sidebar

Open KorigamiK opened this issue 10 months ago • 11 comments

some shortcut to toggle to show the sidebar and expand would be great

KorigamiK avatar Apr 21 '24 14:04 KorigamiK

I would like to have it too, like this:

  1. You have normal vertical bar auto expand on hover
  2. On some hotkey press, the panel would expand nonetheless of mouse position, and take space from the main browser panel. (Similar to Arc)

But this can't be done in CSS alone, as CSS doesn't detect keystrokes whatsoever. We would need extensions on top of this theme like this one. That is fine, but will only be okay as an optional function, as the user needs to manually tweaks things there. But support for this still has to be done somehow.

So, I can't promise this will be implemented, but I will try mentioned extension, to create prototype if this even works.

Kaedriz avatar Apr 21 '24 17:04 Kaedriz

But this can't be done in CSS alone, as CSS doesn't detect keystrokes whatsoever. We would need extensions on top of this theme like this one. That is fine, but will only be okay as an optional function, as the user needs to manually tweaks things there. But support for this still has to be done somehow.

userChrome toggle* definitely for this, you can also open the sidebar with ctrl+b for bookmarks, F1 for sidebery, ctrl+shift+o for library.

soulhotel avatar Apr 21 '24 19:04 soulhotel

Ok, confirmed it in test bed repo, it works well, even animating transition is somewhat possible. The only challenge would be to implement it in this theme, but I can try. Even changing shortcut is possible in user chroma changer, so it would well accessible enough.

Kaedriz avatar Apr 23 '24 13:04 Kaedriz

Okay, branch userchrome-toogler has this functionality implemented for testing purpose, if anyone would want to check it out.

Also, it appears that autohide is broken with tabs width set to S, is that intentional? @soulhotel

Kaedriz avatar Apr 23 '24 15:04 Kaedriz

Okay, branch userchrome-toggler has this functionality implanted for testing purposes. In order to use it, you must download this extension first. The default shortcut for toggling the vertical bar is Shift + Control + 1. AFAIK, you can change it out in Firefox Extensions Shortcuts.

In order to test, I used the following settings: ultima.tabs.autohide set to false ultima.tabs.xs set to true

userchrome-toggle test..webm

Also, is autohide broken when tabs width set to S intentional? @soulhotel EDIT: Ah, nvm, it was probably my test code that overwrote that.

Another potential feature coming from this would be a totally hidden vertical bar, shown only when toggled.

Kaedriz avatar Apr 23 '24 15:04 Kaedriz

Sorry, misclicked completed somehow, didn't notice earlier. The feature is still in development. If you want to test it out, check above.

Kaedriz avatar Apr 23 '24 16:04 Kaedriz

Yeah I got this to work. Userchrome toggle is a nice solution and works nice

KorigamiK avatar Apr 23 '24 16:04 KorigamiK

I'd say this can be merged in right away, the code wont break anything, and its structured specifically for UT (title preface). Good with 126.0b3 also, which has broken a couple of other things in this past week.

soulhotel avatar Apr 23 '24 17:04 soulhotel

Well, I used !important to simply test things out without care for hierarchy. Maybe it could integrate better with existing code. Conditional support for it, maybe.

Kaedriz avatar Apr 23 '24 17:04 Kaedriz

Well, I used !important to simply test things out without care for hierarchy. Maybe it could integrate better with existing code. Conditional support for it, maybe.

Where it says titlepreface ="", i dont want to mess with the code but it has an invisible character there right?

soulhotel avatar Apr 23 '24 17:04 soulhotel

Well, I used !important to simply test things out without care for hierarchy. Maybe it could integrate better with existing code. Conditional support for it, maybe.

Where it says titlepreface ="", i dont want to mess with the code but it has an invisible character there right?

Yes, it slightly messes Title applets on Linux, and maybe Mac, but it's doable. image

VSCode should warn you about it, mine does.

Kaedriz avatar Apr 23 '24 18:04 Kaedriz