soto-core icon indicating copy to clipboard operation
soto-core copied to clipboard

[CI] Use install-swift-tool instead of mint

Open Cyberbeni opened this issue 4 years ago • 3 comments

install-swift-tool also builds tools from source, like mint but it includes caching and avoids the overhead of brew install mint

I believe that the current trigger means that it will generate a cache for every pull request. If we also add a trigger to run on pushes to the default branch then the pull requests could also load it from cache on the first run of every pull request. Source: https://docs.github.com/en/free-pro-team@latest/actions/guides/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache

Cyberbeni avatar Nov 17 '20 19:11 Cyberbeni

Codecov Report

Merging #407 (5d69aef) into main (3fdebac) will increase coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   76.11%   76.13%   +0.02%     
==========================================
  Files          62       62              
  Lines        4831     4831              
==========================================
+ Hits         3677     3678       +1     
+ Misses       1154     1153       -1     
Impacted Files Coverage Δ
...toCore/Credential/CredentialProviderSelector.swift 84.61% <0.00%> (+7.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3fdebac...5d69aef. Read the comment docs.

codecov[bot] avatar Nov 17 '20 19:11 codecov[bot]

Looks like resolving dependencies took an unusually long time but that also happened with mint before. But now if we rerun the sanity check, it should complete in a couple seconds since it would load from cache.

Cyberbeni avatar Nov 17 '20 20:11 Cyberbeni

This would also work on ubuntu, assuming that scripts/sanity.sh works on ubuntu

Cyberbeni avatar Nov 17 '20 20:11 Cyberbeni