sv-witnesses icon indicating copy to clipboard operation
sv-witnesses copied to clipboard

Create python package for linter

Open SvenUmbricht opened this issue 2 years ago • 5 comments

This PR intends to address #27. I have never distributed a package before, so feedback is welcome.

SvenUmbricht avatar Jul 22 '21 11:07 SvenUmbricht

@PhilippWendler Could you please review?

dbeyer avatar Sep 25 '21 09:09 dbeyer

Is this to be assigned to @SvenUmbricht?

PhilippWendler avatar Jan 25 '22 15:01 PhilippWendler

@PhilippWendler Can we merge this? From my side the PR is ready, do you have anything else to add?

SvenUmbricht avatar Feb 07 '22 11:02 SvenUmbricht

@PhilippWendler Can we merge this? From my side the PR is ready, do you have anything else to add?

This PR is for @MartinSpiessl to review and accept, I am just providing some comments. I am also not doing a full review (e.g., I did not actually install Poetry and try everything out, which would of course be needed for a proper review), just telling you when I notice something. And I have no experience with Poetry.

PhilippWendler avatar Feb 07 '22 13:02 PhilippWendler

Regarding poetry: I looked into it and found it to be quite nice (apart from the terrible installation procedure, cf. https://github.com/sosy-lab/sv-witnesses/pull/39#discussion_r812578932), so I would say we can use it for handling packaging etc.
If we encounter any problems in the future, we can still switch to something else. If not we might use it in other projects as well.

MartinSpiessl avatar Feb 23 '22 06:02 MartinSpiessl