sv-witnesses icon indicating copy to clipboard operation
sv-witnesses copied to clipboard

WitnessLinter does not consider different paths in a witness when checking thread information

Open kfriedberger opened this issue 4 years ago • 5 comments

This PR is based on #33 and improves the documentation about the usage of thread identifiers. It also disables the current check for thread creation.

kfriedberger avatar Dec 08 '20 12:12 kfriedberger

I created another PR #35 and will rebase this one when/if the other PR is merged. The branch was rebased.

kfriedberger avatar Dec 08 '20 13:12 kfriedberger

I think the paragraph about createThread is clear and matches the intuition that we all have after the discussion.

I'm not sure I understand the following

The value should be a unique identifer for a thread as long as this thread is active. A thread identifier can be used several times to identify different threads in the program, as long as their execution traces do not interfere. The program trace of a thread can branch or merge along its execution, just the corresponding control flow.

Do we want to say that identifiers uniquely and completely identify active threads? Can we just say the following?

there is a one-to-on mapping between identifiers and active threads

hernanponcedeleon avatar Dec 08 '20 15:12 hernanponcedeleon

Do we want to say that identifiers uniquely and completely identify active threads? Can we just say the following?

there is a one-to-on mapping between identifiers and active threads

Yes, that would also match my intention.

kfriedberger avatar Dec 08 '20 18:12 kfriedberger

In #37, I update the specification for conformity with the upcoming journal paper. I tried to incorporate the improvements suggested here, so that we can publish them with the paper. Specifically, you can see my version of the wording in commit 52cd6d. @kfriedberger: could you please review that part? I used the notion of an automaton run (cf. the literature on automata for the definition) to more precisely describe what I think you meant when you wrote that the execution traces should not interfere.

mdangl avatar Dec 21 '20 10:12 mdangl

@kfriedberger Could you please review the part that @mdangl asked about?

dbeyer avatar Sep 25 '21 09:09 dbeyer