sv-benchmarks icon indicating copy to clipboard operation
sv-benchmarks copied to clipboard

Tasks with expected undefined behavior and another result in several directories

Open PhilippWendler opened this issue 6 years ago • 6 comments

The following tasks all have expected undefined behavior (as indicated by false-valid-deref or false-no-overflow), but also a result for some other property: https://github.com/sosy-lab/sv-benchmarks/blob/50702f8513f655c27b7338b3f363f892958f4ec6/c/check.py#L93-L115 The affected directories are

  • busybox-1.22.0
  • forester-heap
  • heap-manipulation
  • list-ext-properties
  • termination-crafted-lit
  • termination-numeric

Undefined behavior can in theory lead to the violation of any other property, so this makes little sense.

Probably the task should be split into two versions, one identical to the current version but only with the property for undefined behavior, and the other with the undefined behavior fixed.

PhilippWendler avatar Sep 29 '17 14:09 PhilippWendler

Should these tasks simply be renamed to remove the other verdict? Probably it would be better to fix them, but I can't do this.

PhilippWendler avatar Nov 15 '17 07:11 PhilippWendler

@dbeyer What should be do here? Will you contact the authors of these tasks and ask for fixes, or should we remove the label for the other property (the one that does not include undefined behavior)?

@tautschnig has already fixes for the busybox tasks in #513.

PhilippWendler avatar Nov 15 '17 17:11 PhilippWendler

Can this issue be closed? @tautschnig ?

dbeyer avatar Nov 23 '17 12:11 dbeyer

I'm not sure why it's me to comment on this? I have tried to do my share of the work by addressing the issue for those benchmarks that I had originally submitted. It would be nice if the submitters of benchmarks in forester-heap etc. did the same?

tautschnig avatar Nov 24 '17 08:11 tautschnig

Also: no, it cannot be closed AFAIK, because the other directories as listed by @PhilippWendler are still affected.

tautschnig avatar Nov 24 '17 08:11 tautschnig

Assigned @Heizmann and @danieldietsch for cleaning up the labels for the termination directories.

dbeyer avatar Nov 24 '17 09:11 dbeyer